chore: AI Rules for React Spectrum #8319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reidbarber
changed the title
|
Build successful! 🎉 |
snowystinger
approved these changes
Jun 4, 2025
LFDanLu
approved these changes
Jun 17, 2025
| When using server side rendering, the locale prop should be set explicitly on the Provider rather than relying on automatic locale selection. | ||
|
|
||
| [Read more here](mdc:https:/react-spectrum.adobe.com/react-spectrum/getting-started.html) | ||
|
|
There was a problem hiding this comment.
I added the following when using cursor in quarry for the test utils:
## Test writing and test utils
When using server side rendering, the locale prop should be set explicitly on the Provider rather than relying on automatic locale selection.
When writing tests against apps using React Spectrum components, you should try to use the test utils from the `@react-spectrum/test-utils` package. If you are writing tests against apps using React Aria Components, you should try to use the test utils from `@react-aria/test-utils`.
If you are able to browse the web, docs for the test utils can be found at @https://react-spectrum.adobe.com/react-aria/testing.html#react-aria-test-utils- and
https://react-spectrum.adobe.com/react-spectrum/testing.html#react-spectrum-test-utils- respectively. Supported aria patterns can be found in the https://react-spectrum.adobe.com/react-spectrum/testing.html#patterns
and https://react-spectrum.adobe.com/react-aria/testing.html#patterns sections, with links pointing to documentation for
each individual pattern. Prioritize using these docs and looking at ".test." files as examples in https://github.com/adobe/react-spectrum for the specific "createTester" pattern when looking up the API usage.
### Patterns
- Combobox
- GridList
- ListBox
- Menu
- Select
- Table
- Tabs
- Tree
which seemed to work pretty decently. Happy to get this merged in as is, but if you have any feedback or would like to include this section as well lemme know
There was a problem hiding this comment.
Looks good! Feel free to create a PR, or we can give it some time to see if we have any other improvements, and batch them in later with any React Aria rules we add.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rules that you can place in your project to help your coding agent (i.e. Cursor) perform better when using various React Spectrum libraries.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: